masahi commented on a change in pull request #7438:
URL: https://github.com/apache/tvm/pull/7438#discussion_r597177115
##########
File path: tests/scripts/task_python_frontend.sh
##########
@@ -31,6 +31,9 @@ find . -type f -path "*.pyc" | xargs rm -f
# Rebuild cython
make cython3
+# Only run GPU enabled tests on GPU
+export PYTEST_ADDOPTS="-m gpu $PYTEST_ADDOPTS"
Review comment:
ok, surprised to hear that `use_gpu` doesn't do anything. Let's make it
```
PYTEST_ADDOPTS="-m gpu $PYTEST_ADDOPTS" run_pytest cython
python-frontend-onnx tests/python/frontend/onnx
```
This should only modify env vars when running the onnx test.
Also, can you go through `TODO(mbrookhart)` in the onnx frontend test and
add `use_gpus`? There are about 10-15 of them.
https://github.com/apache/tvm/blob/3beec22264f56f734de7d14cd6382b96e83e280a/tests/python/frontend/onnx/test_forward.py#L277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
