comaniac commented on pull request #7731:
URL: https://github.com/apache/tvm/pull/7731#issuecomment-806008203
If the purpose is just for testing, then I'll prefer to have them in a
single pass. You can still test the pattern one-by-one as SimplifyExpr does
now. Since the unrelated patterns won't be matched, I didn't see the problem of
testing. In this case, you can also control the order of rewriting patterns.
i.e., always run `EliminateIdentity` before `FullElementWise` in the
SimplifyExpr pass. This can also reduce the possible confusion from users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
