altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600785922
########## File path: src/relay/transforms/concretize_like.cc ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file concretize_like.cc + * \brief Converts `*_like` operators to their explicit shape equivalent (e.g. `zeros_like(x, y)` to + * `zeros(x, y.shape)`), when the target shape is concrete. This removes unnecessary dependencies + * and can enable more opportunities for operator fusion. + */ + +#include <tvm/relay/transform.h> + +#include "pattern_utils.h" +#include "simplify_expr.h" + +namespace tvm { +namespace relay { + +class ConcretizeLikeRewrite : public DFPatternRewrite { + public: + explicit ConcretizeLikeRewrite(const Op& op) { + ICHECK(op->num_inputs == 1 || op->num_inputs == 2) + << "ConcretizeLike does not handle operators that aren't unary or binary, got: " << op; + like_pat_ = IsWildcard(); + data_pat_ = IsWildcard(); + if (op->num_inputs == 1) { + pattern_ = IsExpr(op)({like_pat_}); + } else { + pattern_ = IsExpr(op)({data_pat_, like_pat_}); + } + require_type_ = true; + } + + virtual bool Check(const Expr& pre, const Expr& post, + const Map<DFPattern, Array<Expr>>& node_map) const { + const CallNode* call_node = pre.as<CallNode>(); + ICHECK(call_node); + + if (!call_node->checked_type_.defined()) { + // TODO(@altanh): maybe because of the input being rewritten? Review comment: I ended up removing this, I think the checked type should always be defined for the `pre` node when `require_type` is true. Previously I was getting the type from a different node which was the wrong approach, now this works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
