altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806028276
Ah, well looks like this might only make sense for constants that only have one element, unless we want to loop over every single element and check that it is equal to 0 or 1. But if I understand correctly, the `FullElementwise` pass only rewrites to scalar constants so those will be rewritten correctly; it's just that if the input IR has non-scalar constants that it won't be simplified. Do you guys think this is a reasonable tradeoff? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
