rkimball edited a comment on pull request #7766: URL: https://github.com/apache/tvm/pull/7766#issuecomment-810390062
@mdw-octoml You are correct. This PR is wrong but there is still a problem with addresses which needs to be fixed. I will revert all of the current changes and submit new changes that correct the issues I am having on windows. I would close this PR and create a new one, but there is good discussion here that I would like to preserve. Question to you and @tqchen: Currently when we create the tracker we pass in the "host" address of 0.0.0.0 which is fine and the tracker has a property "host" which returns the "host address" of the tracker which is not fine. The tracker likely has multiple addresses, one for each of the network interfaces and returning the "host address" of the tracker is confusing, which of the multiple host addresses would a client connect to? The client is normally told explicitly via a command-line parameter which address to connect to. I would like to remove the "host" property of the tracker. Currently the tracker host property returns 0.0.0.0 which is not the address a client would use to connect to the tracker. We also need to disambiguate the address of the tracker in the code, which uses `host` and `tracker_host` interchangeably. The tracker host should be consistently called `tracker_host` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
