masahi commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r667584153



##########
File path: src/tir/transforms/lower_thread_allreduce.cc
##########
@@ -33,10 +33,33 @@
 
 #include "../../runtime/thread_storage_scope.h"
 #include "ir_utils.h"
+#include "update_pointer_storage_scope.h"
 
 namespace tvm {
 namespace tir {
 
+class UpdatePointerStorageScopeAllReduce final : public 
UpdatePointerStorageScope {

Review comment:
       This `attr::volatile_scope` is created inside this `AllocateNode` 
visitor. A visitor for `AttrStmtNode` don't get to see this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to