csullivan commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r668144726
##########
File path: src/tir/transforms/update_pointer_storage_scope.cc
##########
@@ -0,0 +1,91 @@
+/*
Review comment:
I think we need to also update `lower_device_storage_access_info.cc` to
use the PointerType storage scope in this PR as well.
With a custom storage scope used in a cache_read stage, e.g.
```
s.cache_read(data, "global.texture", [OL])
```
I see that
[lower_device_storage_access_info.cc#L72](https://github.com/apache/tvm/blob/main/src/tir/transforms/lower_device_storage_access_info.cc#L72)
is unhappy with the scope tag.
```
Check failed: (e.info.defined()) is false: Cannot find memory info of
global.texture
```
##########
File path: src/tir/transforms/update_pointer_storage_scope.cc
##########
@@ -0,0 +1,91 @@
+/*
Review comment:
I think we need to also update `lower_device_storage_access_info.cc` to
use the PointerType storage scope in this PR as well.
With a custom storage scope used in a cache_read stage, e.g.
```
s.cache_read(data, "global.texture", [OL])
```
I see that
[lower_device_storage_access_info.cc#L72](https://github.com/apache/tvm/blob/main/src/tir/transforms/lower_device_storage_access_info.cc#L72)
is unhappy with the scope tag.
```
Check failed: (e.info.defined()) is false: Cannot find memory info of
global.texture
```
and this ICHECK failure does not occur on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
