csullivan commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r668312348
##########
File path: src/tir/transforms/update_pointer_storage_scope.cc
##########
@@ -0,0 +1,91 @@
+/*
Review comment:
Thanks @masahi. I tracked this issue down to the buffer storage scope
being set to `global` and removing the scope tag. Previously this was fine as
the AttrStmtNode realize_scope annotation was used during texture lowering.
This demonstrate the value in removing the buffer storage scope in favor of
consolidating around the PointerType's storage_scope. I look forward to that
PR! Thanks again for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
