tqchen edited a comment on pull request #8472: URL: https://github.com/apache/tvm/pull/8472#issuecomment-880126991
Thanks @d-smirnov . Given that this will bring a non-trival change to the key TIR data structure, it might be worth discussing it first. In particular, up until now we have avoided the constant node in the low level because the specific implementation can really differ in different backends. Specific allocations might and data copy might be needed on devices with special memory. So from the general architecture PoV we want to avoid the allocate constant node. But instead have a way to point to the global data section. It would be great to discuss the motivation and possible alternatives. My understanding is that we have a potential need to embed parameters into the data segments. We might be able to do things differently. e.g. introduce a constant data segment to IRModule and allow TIR to refer to these global Vars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
