manupa-arm commented on pull request #8472: URL: https://github.com/apache/tvm/pull/8472#issuecomment-880150504
Hi @tqchen , Thanks for taking a look at this. Our initial plan is to use this to support link-param implementation via faithfully expressing them in the TIR -- thus it could get lowered to using current link-param code generation (There is a subsequent PR to this effect). In a way, this will "bound" to IR only if the user provides link-param argument. If the specific implementation requires, the constants to be specially handled in the application layer, we think that is use-case where --link-params is not provided, in which case FuseOps will lift the constant tensor out of the IR into arguments (p0, p1, etc) One of the motivation, this allows compiled constant artifacts to be expressed in the IR (e.g. compressed weights). Moreover, it allows the USMP to pool constants into pool in a clear fashion with ultimate goal of exposing them out of the "main" function. Therefore, I dont think ability to expresse non-scalar constants always force us to define a general lowering for all targets rather it allows the ability to perform analysis/mutations/pooling of such constants before they being lifted out. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
