manupa-arm edited a comment on pull request #8472: URL: https://github.com/apache/tvm/pull/8472#issuecomment-880214469
Hmmm, we do view the tir.allocate_const having closer semantics to tir.allocates, the difference being the former have data inside of it unlike the tir.allocate. The existing TIR anyway treats non-scalar constant data as opaque vars passed in, therefore, I dont quite follow why existing passes get effected. (because we are expressing more information about a var that used to be an input). Despite not seeing the effect on the existing passes, the alternatives would be to define the constant data within a boundary of a PrimFunc. The ability to define constants within the scope of PrimFunc allows specialized lowering of Relay to TIR express the compiled constants with proximity to the PrimFunc while enabling the use of TIR (USMP or otherwise) Passes of TVM. To explore the alternative you mentioned a bit, what do you think about positioning that Map inside the PrimFunc or using function attrs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
