electriclilies edited a comment on pull request #8750: URL: https://github.com/apache/tvm/pull/8750#issuecomment-899679386
@junrushao1994 @tqchen Thanks for the feedback. To me, it makes more sense that `GetAttr` is a method on `DictAttrs`. When it's a standalone method on functions and modules, it's not clear what the attributes that GetAttr is accessing actually are. Also, it'll still show up as a method on `DictAttrs` within the FunctionNode, so people will still be able to see it. One possibility is to add `GetAttr`back as a method on `BaseFunc` and `IRModule`, but have that method just call `DictAttr`'s `GetAttr` method. What do you think about that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
