tqchen edited a comment on pull request #8750: URL: https://github.com/apache/tvm/pull/8750#issuecomment-899680793
Thanks @electriclilies "One possibility is to add GetAttrback as a method on BaseFunc and IRModule, but have that method just call DictAttr's GetAttr method." is exactly what I meant by "keep a common impl as well and redirect in the function and module case". I get your take on the need of a standalone common method, which in some sense can be seen as a tradeoff in the C0 listed above. The addiitional considetations "C1: API consitency: " and C2 puts a bit more weight on explicit functions on the explicit API on the function/module side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
