mbs-octoml commented on pull request #8750: URL: https://github.com/apache/tvm/pull/8750#issuecomment-899829390
LGTM. Returning to Junru's q: "would love to discuss a little bit if this design is the direction we want to move forward or move away from: I am not so sure about DictAttrs itself." I like that CallNode uses Attrs which can be subclassed to be the exact structure we care about (eg OnDeviceAttrs). Since transformations need to be loosely coupled we can't really ask IRModule to be similarly statically typed. So yeah, it sure does look like a plain old Map<...>. But I do like the WithAttrs pattern, and we can get used to that being the usual way of extending attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
