vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r693533655
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
This logic is not working out (CI is failing). I think it is generally
better to have single if block rather than using a nested approach. For example:
```
if (NOT...)
elseif (EXISTS...)
elseif (EXISTS...)
else()
```
I double checked the docker image and the Verilator include dir is in
`/usr/local/share/verilator/include`...here is some proof:
```
$ docker run --rm -it tvm_verilator bash
root@e7d413bdbd90:/# which verilator
/usr/local/bin/verilator
root@e7d413bdbd90:/# ls /usr/local/share/verilator/include/
gtkwave verilated_cov.cpp verilated_heavy.h
verilated_syms.h verilated_vcd_sc.cpp
verilated.cpp verilated_cov.h verilated_imp.h
verilated_threads.cpp verilated_vcd_sc.h
verilated.h verilated_cov_key.h verilated_intrinsics.h
verilated_threads.h verilated_vpi.cpp
verilated.mk verilated_dpi.cpp verilated_save.cpp
verilated_trace.h verilated_vpi.h
verilated.v verilated_dpi.h verilated_save.h
verilated_trace_imp.cpp verilatedos.h
verilated_config.h verilated_fst_c.cpp verilated_sc.h
verilated_vcd_c.cpp vltstd
verilated_config.h.in verilated_fst_c.h verilated_sym_props.h
verilated_vcd_c.h
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
