kparzysz-quic commented on a change in pull request #8823:
URL: https://github.com/apache/tvm/pull/8823#discussion_r695041801
##########
File path: python/tvm/target/target.py
##########
@@ -413,79 +413,117 @@ def bifrost(model="unknown", options=None):
return Target(" ".join(["opencl"] + opts))
-def hexagon(cpu_ver="v66", sim_args=None, llvm_args=None, hvx=128):
+def hexagon(cpu_ver="v66", **kwargs):
Review comment:
I'll revisit the other comments a bit later. The general idea there was
to create sim/llvm/etc strings from the "target configuration", which is
represented by `args` and `cpu_ver`. This is why all the string-generating
functions take the same arguments, even if some of these arguments aren't
necessary, or are already available without parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
