zxybazh commented on a change in pull request #8823:
URL: https://github.com/apache/tvm/pull/8823#discussion_r695086664



##########
File path: python/tvm/target/target.py
##########
@@ -413,79 +413,117 @@ def bifrost(model="unknown", options=None):
     return Target(" ".join(["opencl"] + opts))
 
 
-def hexagon(cpu_ver="v66", sim_args=None, llvm_args=None, hvx=128):
+def hexagon(cpu_ver="v66", **kwargs):

Review comment:
       Thanks for the clarification. It would be fine to me if you want to keep 
the `args` variable this way. Would appreciate a few lines of docs explaining 
the reason. Please feel free to the remove the argument related issues I 
proposed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to