kparzysz-quic commented on a change in pull request #8823:
URL: https://github.com/apache/tvm/pull/8823#discussion_r695984580
##########
File path: python/tvm/target/target.py
##########
@@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None):
return Target(" ".join(["opencl"] + opts))
-def hexagon(cpu_ver="v66", sim_args=None, llvm_args=None, hvx=128):
+def hexagon(cpu_ver="v66", **kwargs):
"""Returns a Hexagon target.
Parameters
----------
- cpu_ver : str
+ cpu_ver : str (default: "v66")
Review comment:
From what I saw in the Vulkan code, it seems like the device information
is obtained by directly querying Vulkan runtime.
In case of Hexagon, the compilation will almost always happen on a machine
without any Hexagon hardware present. If anything, the situation here may be
the reverse of the Vulkan case---the Target would be the definition from which
DeviceAPI would be created. At execution time, if the actual hardware does not
meet the criteria given by the Target, the execution could simply fail with a
message.
In general, having a Hexagon phone plugged into an x86-based PC does not
really make it easy to query it, as most libraries in the Hexagon SDK are built
for either Hexagon itself or for ARM/AArch64. Users would normally do `adb
shell` and look for configuration details in the files in the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
