jtuyls commented on a change in pull request #9425:
URL: https://github.com/apache/tvm/pull/9425#discussion_r744615448



##########
File path: docker/install/ubuntu_install_rocm.sh
##########
@@ -21,10 +21,10 @@ set -u
 set -o pipefail
 
 # Install ROCm cross compilation toolchain.
-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key 
add -
-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > 
/etc/apt/sources.list.d/rocm.list
+wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | 
sudo tee /etc/apt/sources.list.d/rocm.list

Review comment:
       Btw, there are some rocm tests here: 
https://github.com/apache/tvm/blob/main/tests/python/unittest/test_target_codegen_rocm.py
 but I don't think they are actually being run inside the ci-gpu regressions? 
Otherwise, we should have encountered these version issues earlier?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to