masahi commented on a change in pull request #9425: URL: https://github.com/apache/tvm/pull/9425#discussion_r745065510
########## File path: docker/install/ubuntu_install_rocm.sh ########## @@ -21,10 +21,10 @@ set -u set -o pipefail # Install ROCm cross compilation toolchain. -wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key add - -echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > /etc/apt/sources.list.d/rocm.list +wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add - +echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | sudo tee /etc/apt/sources.list.d/rocm.list Review comment: I've never used `ci-gpu` locally, so I'm not sure. But I wouldn't be surprised if rocm tests are not exercised at all. Yes, if rocm 4.3 is intended to be used with TVM in a docker, llvm should also be upgraded to 13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
