Mousius commented on a change in pull request #9395:
URL: https://github.com/apache/tvm/pull/9395#discussion_r745466545
##########
File path: src/target/target_kind.cc
##########
@@ -373,6 +373,8 @@ TVM_REGISTER_TARGET_KIND("hybrid", kDLCPU) // line break
TVM_REGISTER_TARGET_KIND("composite",
kDLCPU).add_attr_option<Array<Target>>("devices");
+TVM_REGISTER_TARGET_KIND("ethos-u", kDLCPU).set_attr<Bool>("c_device_api",
Bool(true));
Review comment:
I think my nervousness here stems from enabling the Device API when the
runtime doesn't support it. Given the C++ runtime uses the `Module` nodes
rather than C functions, `Target`s could enumerate support rather than enabling
all Device APIs?
I'm happy to change this to `use_device_api` to match the RFC as I think
there's bigger problems with enumerating the internal support for runtimes and
executors but curious on your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
