mbs-octoml commented on a change in pull request #9395:
URL: https://github.com/apache/tvm/pull/9395#discussion_r746824449
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -637,6 +681,7 @@ class AOTExecutorCodegen : public MixedModeVisitor {
main_signature_.push_back(tir::Var("output", DataType::Handle()));
}
+ CollectDeviceVariables(lowered_mod->GetAttr<Map<GlobalVar,
String>>("device_contexts").value());
Review comment:
> Internally to the TECompiler, the representation of the BYOC function
gets changed to a GlobalVar after the name gets uniquified, and the annotation
gets removed, so until everything gets persisted naturally all the way down I
can't get to it sensibly without this
Hmm, ok, so you're still on the BYOC compilation notion of 'target' while
I'm on the, well, Target notion of 'target'.
Even so, you can avoid the IRModule attribute map by annotating the
PrimFunc, right? That's at least closer to the ultimate goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
