areusch commented on a change in pull request #9395: URL: https://github.com/apache/tvm/pull/9395#discussion_r746795050
########## File path: apps/microtvm/ethosu/src/tvm_ethosu_runtime.c ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "tvm_ethosu_runtime.h" + +#include <ethosu_driver.h> + +int32_t TVMEthosULaunch(struct ethosu_driver* driver, void* cms_data, size_t cms_data_size, + uint64_t* base_addrs, size_t* base_addrs_size, int num_tensors) { + int32_t result = + ethosu_invoke(driver, cms_data, cms_data_size, base_addrs, base_addrs_size, num_tensors); + + // Map errors in invoke to TVM errors + if (result != 0) { + return -1; Review comment: right, i think adopting the != 0 convention is fine here. just was curious whether you had a TODO to try and map into the error space or if the comment was descriptive and you wanted to keep as-is. sounds like the latter, which is fine one thing i had semi-speculatively adopted was: if the top bit is 1, the error is a system-specific thing. curious if that is helpful here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
