Mousius commented on a change in pull request #9395:
URL: https://github.com/apache/tvm/pull/9395#discussion_r746830667



##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -637,6 +681,7 @@ class AOTExecutorCodegen : public MixedModeVisitor {
       main_signature_.push_back(tir::Var("output", DataType::Handle()));
     }
 
+    CollectDeviceVariables(lowered_mod->GetAttr<Map<GlobalVar, 
String>>("device_contexts").value());

Review comment:
       The Call gets translated to `Call(GlobalVar)`, the `PrimFunc` is just a 
stub one for the TE Compiler and because the function name may change I can't 
find the eventual `Function` again. Even if I could guarantee the `GlobalVar` 
didn't change, and find the `Function`, the annotation gets stripped by 
`LowerExternalFunctions`. When this gets revisited the aim would be to not 
remove the annotation, so it can be found again later, I believe it's done now 
because `kCompiler` causes different paths in different parts of the compiler 
which are undesirable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to