jroesch commented on a change in pull request #9693:
URL: https://github.com/apache/tvm/pull/9693#discussion_r767034518
##########
File path: include/tvm/target/se_scope.h
##########
@@ -170,7 +170,7 @@ class SEScopeNode : public AttrsNode<SEScopeNode> {
*
* kInvalidDeviceType denotes unconstrained.
*/
- int device_type_int;
+ int /* actually DLDeviceType */ device_type_int;
Review comment:
Should we make these private in C++?
##########
File path: src/relay/transforms/device_planner.cc
##########
@@ -20,6 +20,10 @@
/*!
* \file src/relay/transforms/device_planner.cc
* \brief Determines a unique \p SEScope to hold the result of every Relay
sub-expression.
+ * This pass can be run multiple times, and can be run both before and after
lowering.
+ *
+ * TODO(mbs): Rename SEScope |-> VirtualDevice, and use 'virtual device' (or
just 'device')
Review comment:
I think we can do this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
