mbs-octoml commented on a change in pull request #9693:
URL: https://github.com/apache/tvm/pull/9693#discussion_r768009277
##########
File path: src/relay/op/memory/on_device.h
##########
@@ -39,14 +39,50 @@ namespace relay {
const Op& OnDeviceOp();
/*!
- * \brief Wraps \p expr in an "on_device" CallNode for \p se_scope and \p
is_fixed.
+ * \brief Wraps \p body in an "on_device" CallNode for \p se_scope.
*
* See \p OnDeviceAttrs for an overview.
*/
-Expr OnDevice(Expr expr, SEScope se_scope, bool is_fixed);
+Call OnDevice(Expr body, SEScope se_scope, bool constrain_result = false,
+ bool constrain_body = true);
+
+/*! \brief Result of \p GetOnDeviceProps. */
+struct OnDeviceProps {
+ Expr body; // = null
+ SEScope se_scope = SEScope::FullyUnconstrained();
+ bool constrain_result = false;
+ bool constrain_body = false;
+
+ OnDeviceProps() = default;
+
+ OnDeviceProps(Expr body, SEScope se_scope, bool constrain_result, bool
constrain_body)
+ : body(std::move(body)),
+ se_scope(std::move(se_scope)),
+ constrain_result(constrain_result),
+ constrain_body(constrain_body) {}
+
+ bool is_fixed() const { return constrain_result && constrain_body; }
+ bool is_normal() const { return !constrain_result && constrain_body; }
+};
+
+/*!
+ * \brief As for OnDevice, but taking all fields other than \p body from \p
props.
+ */
Review comment:
np, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
