mbs-octoml commented on a change in pull request #9693:
URL: https://github.com/apache/tvm/pull/9693#discussion_r768004662
##########
File path: src/relay/op/memory/on_device.cc
##########
@@ -45,53 +43,74 @@ const Op& OnDeviceOp() {
return op;
}
-Expr OnDevice(Expr expr, SEScope se_scope, bool is_fixed) {
- ICHECK(!se_scope->IsFullyUnconstrained());
+Call OnDevice(Expr body, SEScope se_scope, bool constrain_result, bool
constrain_body) {
+ ICHECK((!constrain_result && !constrain_body) ||
!se_scope->IsFullyUnconstrained());
auto attrs = make_object<OnDeviceAttrs>();
- attrs->se_scope = std::move(se_scope);
- attrs->is_fixed = is_fixed;
- Span span = expr->span;
- return Call(OnDeviceOp(), {std::move(expr)}, Attrs(std::move(attrs)),
/*type_args=*/{},
+ attrs->se_scope =
+ (constrain_result || constrain_body) ? std::move(se_scope) :
SEScope::FullyUnconstrained();
+ attrs->constrain_result = constrain_result;
+ attrs->constrain_body = constrain_body;
+ Span span = body->span; // about to be moved
Review comment:
I later move the body, so need to grab the span (reference) first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
