jroesch commented on a change in pull request #9980:
URL: https://github.com/apache/tvm/pull/9980#discussion_r788017534
##########
File path: include/tvm/runtime/object.h
##########
@@ -372,8 +372,8 @@ class ObjectPtr {
template <typename U>
ObjectPtr(const ObjectPtr<U>& other) // NOLINT(*)
: ObjectPtr(other.data_) {
- static_assert(std::is_base_of<T, U>::value,
- "can only assign of child class ObjectPtr to parent");
Review comment:
Agree with TQ this should not be remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
