jroesch commented on a change in pull request #9980:
URL: https://github.com/apache/tvm/pull/9980#discussion_r788019743
##########
File path: include/tvm/runtime/vm/vm.h
##########
@@ -300,7 +300,7 @@ class VirtualMachine : public runtime::ModuleNode {
/*! \brief The special return register. */
ObjectRef return_register_;
/*! \brief The executable the VM will operate on. */
- Executable* exec_;
+ ObjectPtr<Executable> exec_;
Review comment:
If you get Executable an ObjectRef wrapper like the rest of the code
base you can then use the down casting machinery built on-top of ObjectRef. It
might make working with this type easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
