vvchernov commented on a change in pull request #9980:
URL: https://github.com/apache/tvm/pull/9980#discussion_r790513538
##########
File path: include/tvm/runtime/vm/vm.h
##########
@@ -174,7 +174,7 @@ class VirtualMachine : public runtime::ModuleNode {
* \brief load the executable for the virtual machine.
* \param exec The executable.
*/
- virtual void LoadExecutable(Executable* exec);
+ virtual void LoadExecutable(const ObjectRef& exec);
Review comment:
It was advice from @jroesch to use ObjectRef. And it seems the simplest
way from possible ones. I agree that using of ObjectPtr<Executable> is
preferable but to get it correctly is not so simple task (see below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
