junrushao1994 commented on a change in pull request #8509:
URL: https://github.com/apache/tvm/pull/8509#discussion_r791023431



##########
File path: include/tvm/ir/module.h
##########
@@ -349,6 +393,9 @@ class IRModuleNode : public Object {
    */
   std::unordered_set<String> import_set_;
   friend class IRModule;
+
+ public:
+  void ExtractPrimFuncConstants(tir::PrimFunc func);

Review comment:
       Yeah I wanted to second @manupa-arm here :-) Usually we don't add these 
specific methods attached to IRModule




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to