junrushao1994 commented on a change in pull request #8509:
URL: https://github.com/apache/tvm/pull/8509#discussion_r801876749
##########
File path: include/tvm/ir/module.h
##########
@@ -349,6 +386,9 @@ class IRModuleNode : public Object {
*/
std::unordered_set<String> import_set_;
friend class IRModule;
+
+ public:
+ void ExtractConstants(BaseFunc func);
Review comment:
Usually we do not in-place mutate the IR, but instead do copy-on-write.
Therefore, I would prefer to extract this method as a separate pass under
`src/ir` or `src/tir`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
