junrushao1994 commented on a change in pull request #8509:
URL: https://github.com/apache/tvm/pull/8509#discussion_r801880959
##########
File path: include/tvm/tir/transform.h
##########
@@ -492,6 +500,8 @@ TVM_DLL Pass ConvertForLoopsToSerial();
*/
TVM_DLL Pass UnifiedStaticMemoryPlanner();
+TVM_DLL Pass BindParams(const std::vector<const relay::ConstantNode*>&
constants);
Review comment:
Let's consider `vector<const ConstantNode*>` vs `Array<NDArray>`. The
latter option will be consistent with TVM's convention where the Pass object
can be used in both C++ and Python. Would you like to briefly explain the
reason why we need "ConstantNode" (which is relay-specific) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
