masahi commented on a change in pull request #10108:
URL: https://github.com/apache/tvm/pull/10108#discussion_r796059162
##########
File path: src/runtime/opencl/opencl_device_api.cc
##########
@@ -122,7 +123,8 @@ void OpenCLWorkspace::GetAttr(Device dev, DeviceAttrKind
kind, TVMRetValue* rv)
corresponding to the number of SIMD entries the heardware
configures.
We need to figure out a way to query this information from the
hardware.
*/
- *rv = 1;
+ const int warp_size = dmlc::GetEnv("TVM_OPENCL_WARP_SIZE", 1);
Review comment:
That reminds me of the fact that it is already possible to set HW params
from a python script
https://github.com/apache/tvm/blob/main/gallery/how_to/tune_with_autoscheduler/tune_network_mali.py#L188-L194
So in practice, this patch might not be necessary. But since the possibility
to manually specify HW params is not known well and cumbersome anyway, I still
want to land this PR. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]