huajsj commented on a change in pull request #10530:
URL: https://github.com/apache/tvm/pull/10530#discussion_r823179659
##########
File path: python/tvm/driver/build_module.py
##########
@@ -275,7 +275,7 @@ def build(
annotated_mods, target_host =
Target.check_and_update_host_consist(annotated_mods, target_host)
- rt_mod_host = _driver_ffi.preprocess_module(annotated_mods, target_host)
+ rt_mod_host = _driver_ffi.build(annotated_mods, target_host)
Review comment:
There are some difference related "overrode the target host" logic
between 'preprocess_module' and 'build', is this change may fix any potential
corner case or cause any new corner case issue?
##########
File path: python/tvm/driver/build_module.py
##########
@@ -275,7 +275,7 @@ def build(
annotated_mods, target_host =
Target.check_and_update_host_consist(annotated_mods, target_host)
- rt_mod_host = _driver_ffi.preprocess_module(annotated_mods, target_host)
+ rt_mod_host = _driver_ffi.build(annotated_mods, target_host)
Review comment:
There are some difference related "overrode the target host" logic
between 'preprocess_module' and 'build', is this change may fix any potential
corner case or cause any new corner case issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
