Lunderberg commented on a change in pull request #10530:
URL: https://github.com/apache/tvm/pull/10530#discussion_r826044331
##########
File path: src/driver/driver_api.cc
##########
@@ -442,68 +442,6 @@ std::pair<IRModule, IRModule> SplitMixedModule(IRModule
mod_mixed, const Target&
return {host_mod, device_mod};
}
-runtime::Module PreProcessModuleForBuild(const Map<Target, IRModule>&
inputs_arg,
Review comment:
Looking at it with fresh post-weekend eyes, it looks like this function
is already part of the external API, [as one of the overloads for
`tvm::build`](https://github.com/apache/tvm/blob/main/include/tvm/driver/driver_api.h#L156).
As a proposal for naming conventions, I've made an internal
`tvm::TIRToRuntime`, with the name chosen to mimic the [existing
target-specific codegen
hook](https://github.com/apache/tvm/blob/main/src/target/codegen.cc#L50). All
internal usage calls `tvm::TIRToRuntime` directly, while the `tvm::build`
overload is maintained for the external API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
