Lunderberg commented on a change in pull request #10530:
URL: https://github.com/apache/tvm/pull/10530#discussion_r823721818
##########
File path: src/driver/driver_api.cc
##########
@@ -442,68 +442,6 @@ std::pair<IRModule, IRModule> SplitMixedModule(IRModule
mod_mixed, const Target&
return {host_mod, device_mod};
}
-runtime::Module PreProcessModuleForBuild(const Map<Target, IRModule>&
inputs_arg,
Review comment:
Good point, since `build` is used pretty frequently elsewhere, and could
be confusing to users. Since most places use "build" to refer to generating
something that is executable, I thought it would be appropriate here. But I
think I agree, since in most places "build" has an entire sequence of steps,
and here there's only the one.
I'm not a big fan of the name `PreProcessModuleForBuild`, because I read
"PreProcess" as implying that this is a pretty early step in the build
pipeline, rather than being nearly the last step.
The best name coming to mind is `CodeGenerationForLowLevelTIR` or
`GenerateCodeForLowLevelTIR`, but waiting for the caffeine to hit may result in
better names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
