tqchen commented on a change in pull request #10686:
URL: https://github.com/apache/tvm/pull/10686#discussion_r830508197
##########
File path: tests/python/unittest/test_auto_scheduler_feature.py
##########
@@ -220,12 +220,15 @@ def tir_matmul(
def test_primfunc():
- features = auto_scheduler.feature.named_features_from_primfunc(tir_matmul)
Review comment:
Would be good to keep the original pass because that is the original
intended usage, since the original function was designed for auto-scheduler
with limited passes (to enable fast feature extraction). The test should cover
the original intended use.
The additional support enables possible explorations for new use cases.
Consider add another testcase test_primfunc_lowered_with_let to get the fully
lowered version.
It would be helpful to construct a simplified TVM script version of the
lowered version to see exactly where let bound may results in a change of
values.
##########
File path: tests/python/unittest/test_auto_scheduler_feature.py
##########
@@ -220,12 +220,15 @@ def tir_matmul(
def test_primfunc():
- features = auto_scheduler.feature.named_features_from_primfunc(tir_matmul)
Review comment:
Would be good to keep the original test because that is the original
intended usage, since the original function was designed for auto-scheduler
with limited passes (to enable fast feature extraction). The test should cover
the original intended use.
The additional support enables possible explorations for new use cases.
Consider add another testcase test_primfunc_lowered_with_let to get the fully
lowered version.
It would be helpful to construct a simplified TVM script version of the
lowered version to see exactly where let bound may results in a change of
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
