tkonolige commented on a change in pull request #10686:
URL: https://github.com/apache/tvm/pull/10686#discussion_r831343472
##########
File path: tests/python/unittest/test_auto_scheduler_feature.py
##########
@@ -220,12 +220,15 @@ def tir_matmul(
def test_primfunc():
- features = auto_scheduler.feature.named_features_from_primfunc(tir_matmul)
Review comment:
> To rephrase what you are saying (correct if that was not what you
meant):
> - In the future, if CSE changes its behavior to generate other cases, the
feature extractor from an explicit tvm-script may not capture that changes (as
new CSE will generate new IRs that may have other properties) -- the test won't
fail but I guess you mean it fails to capture the possible problem in CSE
changes.
What I mean is that I want a test that ensures that changes to the lowering
pipeline do not break feature extraction. CSE is an example of a test that
broke it. I agree that it could be viewed as an integration test and I can move
the test if you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
