tkonolige commented on a change in pull request #10686:
URL: https://github.com/apache/tvm/pull/10686#discussion_r831318078
##########
File path: src/auto_scheduler/feature.cc
##########
@@ -724,6 +731,15 @@ class PerStoreFeatureExtractor : public StmtExprVisitor {
ExtractAllocationFeature(node);
}
+ void VisitStmt_(const LetStmtNode* node) final {
+ // TODO(tkonolige): add arithmetic counts from this statement to counts of
inner stores.
+ ana_.Bind(node->var, node->value);
+ ICHECK(variable_definition_stack_.size() > 0)
+ << "Variable definition out size of a for loop is not handled by
feature extraction";
+ variable_definition_stack_.back().push_back(std::make_tuple(node->var,
node->value));
+ StmtExprVisitor::VisitStmt_(node);
Review comment:
No, the variable_definition_stack_ has entries on a per loop basis not a
per let stmt basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
