Lunderberg commented on code in PR #11097:
URL: https://github.com/apache/tvm/pull/11097#discussion_r856593303
##########
python/tvm/script/context_maintainer.py:
##########
@@ -233,7 +240,7 @@ def lookup_symbol(self, name: str) ->
Optional[Union[Buffer, Var]]:
for symbols in reversed(self.symbols):
if name in symbols:
return symbols[name]
- return None
+ return self.closure_vars.get(name)
Review Comment:
And it looks like this recommended change also causes some of the passing
tests in https://gist.github.com/Lunderberg/dd38f82810e4e06c0834087d4a96bda9 to
fail, such as using a meta-parameter as a loop iteration bound. There's
definitely more going on here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
