Hzfengsy commented on PR #11097: URL: https://github.com/apache/tvm/pull/11097#issuecomment-1109232695
Thank you @junrushao1994 for moderating and proposing the actionable items, and thank you all @Lunderberg @masahi @wrongtest for the very inspiring discussion so far! Learned quite a lot by just reading this thread :-) > A1. Decide if the syntax is good for @masahi and @Lunderberg's usecase; Looks like we have reached consensus - excited to see it works for your usecases! > A2. Adjust the PR title, explicitly saying it's template metaprogramming over variables; Thanks. I'm going to change the title to "[TVMScript] Support TVMScript template meta-programming over variables" > A3. Siyuan fixes the unittests and make it pass for this PR; Yay! The CI is green now! > A4. If we all agree on A1 and A2, would love to invite Eric to coauthor this PR, proceed in PR-11062, or in a new PR (whichever way works best for you guys) implementing that idea, with both Siyuan and Eric be listed as coauthors. I agree with Eric that having separate PRs makes most of sense. No need to add me as co-author if I didn't contribute, but I'm happy to review! Besides, while understanding that RFC drafting is time-consuming and painstaking, multiple active community members have been already showing great interest in TVMScript stuff, specifically metaprogramming. To this end, I have a meta point: A5. Even if we didn't have a final draft, @yelite @junrushao1994 would you like to share some preliminary motivating examples or design ideas with the community for broader discussion, also to avoid potential duplication of effort? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
