Lunderberg commented on PR #11097: URL: https://github.com/apache/tvm/pull/11097#issuecomment-1108640643
> A1. Decide if the syntax is good for @masahi and @Lunderberg's usecase; This is sufficient for my use, yes. My primary use case is in writing unit tests, with various shape parameters. > If we'd like to distinguish variables and other asts in script and variables in host language? I think I'd lean against having it different syntax. With the current implementation, meta-parameters in tvmscript appear to a user as if they are nonlocal variables in a python function, which becomes a very easy explanation to teach new users. If we need to make this distinction while parsing to TIR, that can be done by querying the context manager. If we need to make this distinction after generating TIR, I think that would be better done using `PrimFunc.specialize`. > A2. Adjust the PR title, explicitly saying it's template metaprogramming over variables; I agree, changing the title would help emphasize that this is one specific metaprogramming feature, and not the final state of metaprogramming for tvmscript. > A4. If we all agree on A1 and A2, would love to invite Eric to coauthor this PR, proceed in PR-11062, or in a new PR (whichever way works best for you guys) implementing that idea, with both Siyuan and Eric be listed as coauthors. I'm down for any of these options. I think it would make the most sense to have separate PRs, since this PR alone provides tremendous utility, and additional features can be added as bandwidth allows and needs come up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
