masahi commented on PR #11345: URL: https://github.com/apache/tvm/pull/11345#issuecomment-1137153403
Yes, sorry I meant we should use `UpperCamelCase` instead of `lowerCamelCase`. I saw many `lowerCamelCase` in this PR. Since this is a runtime code for one backend and not like the core code, I'd say we don't have to be too strict with this rule. But in general, I think it's better to stick with the convention, unless there is a good reason to deviate (e.g. match coding style with dnnl etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
