apeskov commented on PR #11345: URL: https://github.com/apache/tvm/pull/11345#issuecomment-1142221215
@masahi, I'm slightly confused with coding style. In PR https://github.com/apache/tvm/pull/11111 you approved a new function [dtype_dl2dnnl](https://github.com/apache/tvm/blob/efec735626cb2932df7771bdff60c2e9ff1b14da/src/runtime/contrib/dnnl/dnnl_utils.h#L41). This is definitely not a `CamelCase` naming. In my patch I would like to add several more similar util functions. And what naming I should use? `snake_case` like previous one or `CamelCase` like you requested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
