masahi commented on PR #11345: URL: https://github.com/apache/tvm/pull/11345#issuecomment-1143184845
Yeah, how about this: I don't think using `CamelCase` should be mandatory for all functions. As a general rule of thumb, we should use `CamelCase` by default, but if a person is aware of this general convention but still wants to use `snake_case` for some reasons, I'd say go ahead. In particular, since DNNL uses `snake_case`, I understand that making some util functions be `snake_case` can make the code more natural. I brought this up just because I saw a lot of uses of the style like `makeSolver` in this PR, which seemed arbitrary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
