driazati commented on code in PR #11569:
URL: https://github.com/apache/tvm/pull/11569#discussion_r891485537
##########
tests/scripts/github_tvmbot.py:
##########
@@ -417,11 +433,10 @@ def author(self) -> str:
return self.raw["author"]["login"]
def find_failed_ci_jobs(self) -> List[CIJob]:
- # NEUTRAL is GitHub Action's way of saying cancelled
return [
job
for job in self.ci_jobs()
- if job["status"] not in {"SUCCESS", "SUCCESSFUL", "SKIPPED"}
+ if job["status"] not in {"SUCCESS", "SUCCESSFUL", "SKIPPED",
"NEUTRAL"}
Review Comment:
this change is here is because lots of the PR automation (e.g. the cc bot
and teams tagging) run on every comment, but new runs cancel old runs, so there
are usually a couple cancelled jobs on PRs. We could add a blocklist and just
ignore these job names but most users aren't able to cancel jobs anyways and
this doesn't require being synced manually if we make any changes to those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
