Mousius commented on code in PR #11569:
URL: https://github.com/apache/tvm/pull/11569#discussion_r897711830
##########
tests/scripts/github_tvmbot.py:
##########
@@ -417,11 +435,16 @@ def author(self) -> str:
return self.raw["author"]["login"]
def find_failed_ci_jobs(self) -> List[CIJob]:
- # NEUTRAL is GitHub Action's way of saying cancelled
+ def is_important_job(job):
+ # Ignore GitHub workflows that operate on PRs but don't run tests
+ if job["source"] != "github actions":
+ return True
+ return job["name"].startswith("CI /")
Review Comment:
Argh, it's this difficult to read formatting:
https://github.com/apache/tvm/pull/11569/files#diff-1cf1d75bfab53cc02abbcf96c356bfdbd477fb9d76ed5558d49e426a641c53f8R292-R301
Missed the `+`s instead of `,` in the item, that's what lead to me not
finding the string 😿
To follow up, I'm not clear if de-duplication is no longer tested, or if
this is not tested - looking at the de-duplication fixture the jobs are these:
| name | checkSuite.workflowRun.workflow.name | status |
completedAt | conclusion | url
| state | context | targetUrl
|
| ------------ | ------------------------------------ | --------- |
-------------------- | ---------- |
--------------------------------------------- | ------- | -------------- |
------------------------------------------------------------- |
| cc-reviewers | PR | COMPLETED |
2022-06-01T15:32:23Z | CANCELLED |
https://github.com/apache/tvm/runs/6692618718 | | |
|
| tag-teams | Teams | COMPLETED |
2022-06-01T15:32:21Z | CANCELLED |
https://github.com/apache/tvm/runs/6692618705 | | |
|
| MacOS | CI | COMPLETED |
2022-05-28T00:52:07Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016151 | | |
|
| maybe-merge | Merge | COMPLETED |
2022-06-01T20:08:01Z | SUCCESS |
https://github.com/apache/tvm/runs/6697027810 | | |
|
| cc-reviewers | PR | COMPLETED |
2022-05-27T23:21:28Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016519 | | |
|
| cc-reviewers | PR | COMPLETED |
2022-05-27T23:22:11Z | SUCCESS |
https://github.com/apache/tvm/runs/6633020322 | | |
|
| cc-reviewers | PR | COMPLETED |
2022-06-01T15:34:03Z | SUCCESS |
https://github.com/apache/tvm/runs/6692623314 | | |
|
| tag-teams | Teams | COMPLETED |
2022-05-27T23:21:23Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016525 | | |
|
| tag-teams | Teams | COMPLETED |
2022-05-27T23:22:25Z | FAILED |
https://github.com/apache/tvm/runs/6633020321 | | |
|
| tag-teams | Teams | COMPLETED |
2022-06-01T15:33:09Z | SUCCESS |
https://github.com/apache/tvm/runs/6692621919 | | |
|
| Windows | CI | COMPLETED |
2022-05-28T00:48:58Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016091 | | |
|
| Android | CI | COMPLETED |
2022-05-28T00:31:19Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016015 | | |
|
| | | |
| | |
SUCCESS | tvm-ci/pr-head |
https://ci.tlcpack.ai/job/tvm/job/PR-11455/4/display/redirect |
If we're now filtering it so that anything non-"CI" is ignored, then the
above table reduces to:
| name | checkSuite.workflowRun.workflow.name | status |
completedAt | conclusion | url
| state | context | targetUrl
|
| ------------ | ------------------------------------ | --------- |
-------------------- | ---------- |
--------------------------------------------- | ------- | -------------- |
------------------------------------------------------------- |
| MacOS | CI | COMPLETED |
2022-05-28T00:52:07Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016151 | | |
|
| Windows | CI | COMPLETED |
2022-05-28T00:48:58Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016091 | | |
|
| Android | CI | COMPLETED |
2022-05-28T00:31:19Z | SUCCESS |
https://github.com/apache/tvm/runs/6633016015 | | |
|
| | | |
| | |
SUCCESS | tvm-ci/pr-head |
https://ci.tlcpack.ai/job/tvm/job/PR-11455/4/display/redirect |
Therefore, regardless of de-duplication, this would still pass with the new
logic?
I looked at the `badci` fixture and it appears that also only checks a
Jenkins job rather than the new GitHub actions checks?
Could you please double check we have test cases for both of these states?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
