Mousius commented on code in PR #11569:
URL: https://github.com/apache/tvm/pull/11569#discussion_r892363287
##########
tests/scripts/github_tvmbot.py:
##########
@@ -417,11 +433,10 @@ def author(self) -> str:
return self.raw["author"]["login"]
def find_failed_ci_jobs(self) -> List[CIJob]:
- # NEUTRAL is GitHub Action's way of saying cancelled
return [
job
for job in self.ci_jobs()
- if job["status"] not in {"SUCCESS", "SUCCESSFUL", "SKIPPED"}
+ if job["status"] not in {"SUCCESS", "SUCCESSFUL", "SKIPPED",
"NEUTRAL"}
Review Comment:
My concern would be if we had some window where a previous job had been
cancelled but not yet restarted by GitHub, is that a possibility?
Also, I think we need an additional test with the new status in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
