masahi commented on PR #80:
URL: https://github.com/apache/tvm-rfcs/pull/80#issuecomment-1183694798
Ok @JosephTheOctonaut, thanks for the suggestion. I've update wording and
pseudo code examples to make `async_wait_queue` a scope annotation. There are
non-trivial changes to the code examples, since now `async_wait` is making its
scope explicit. For example, previously we had
```
if i < 1:
async_wait_group(1, 1)
else:
async_wait_group(1, 0)
D[(i + 14) % 2] = C[(i + 14) % 2] + 1
```
This is now
```
if i < 1:
async_wait_group(1, 1):
D[(i + 14) % 2] = C[(i + 14) % 2] + 1
else:
async_wait_group(1, 0):
D[(i + 14) % 2] = C[(i + 14) % 2] + 1
```
@junrushao1994 @vinx13 I think all outstanding issues have been addressed,
ready for a final look and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
